chore: revive against current comline-core - #1
Merged
Conversation
The LSP hadn't been built since the core grammar / IR drifted; it now
compiles and all tests pass (39 + 2 e2e + 4 integration).
- AST declarations are `Spanned<Declaration>` now — deref before
matching (`match &**decl`) in symbols / hover / references.
- `Declaration` gained `Error` / `Settings` / `Validator` — handled
(not surfaced in the outline yet).
- grammar `Type::I8..I64` -> `S8..S64` (signed prefix); `format_type`
gains the `Union` and `Unit` arms the grammar added.
- `comline-core` by git rev (core 50c17cc), like every other repo, so
it builds standalone; a commented `[patch]` for sibling-checkout dev.
- a CI workflow (cargo build + test), matching the other repos.
- trimmed dead imports; `license = "GPL-3.0-only"`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The language server hadn't been built since the
coregrammar / IR drifted. It now compiles and all tests pass (39 unit + 2 e2e + 4 integration).Spanned<Declaration>now — deref before matching (match &**decl) insymbols/hover/references.DeclarationgainedError/Settings/Validator— handled (not surfaced in the outline yet).Type::I8..I64→S8..S64;format_typegains theUnionandUnitarms.comline-corepinned by git rev (core50c17cc) instead of a siblingpath, so it builds standalone — a commented[patch]covers local dev.cargo build+cargo test), matching the other repos.license = "GPL-3.0-only".Next toward the manual-test loop: wire the still-unused handlers (
code_actions,signature_help, workspace symbols) intobackend.rs, and a fresh editor smoke test.